[PATCH] D80297: Inline the printintrincis function

[Zhuoran Yin via Phabricator via llvm-commits]

jerryyin created this revision.
Herald added subscribers: llvm-commits, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: ftynse.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80297

Files:
  mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
  mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp


Index: mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
===================================================================
--- mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
+++ mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
@@ -31,15 +31,9 @@
 using namespace ROCDL;
 
 //===----------------------------------------------------------------------===//
-// Printing/parsing for ROCDL ops
+// Parsing for ROCDL ops
 //===----------------------------------------------------------------------===//
 
-static void printROCDLIntrinsicOp(OpAsmPrinter &p, Operation *op) {
-  p << op->getName() << " " << op->getOperands();
-  if (op->getNumResults() > 0)
-    p << " : " << op->getResultTypes();
-}
-
 static LLVM::LLVMDialect *getLlvmDialect(OpAsmParser &parser) {
   return parser.getBuilder()
       .getContext()
Index: mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
===================================================================
--- mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
+++ mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
@@ -152,7 +152,11 @@
           $slc}, {$_resultType});
   }];
   let parser = [{ return parseROCDLMubufLoadOp(parser, result); }];
-  let printer = [{ printROCDLIntrinsicOp(p, this->getOperation()); }];
+  let printer = [{ 
+    Operation *op = this->getOperation();
+    p << op->getName() << " " << op->getOperands()
+      << " : " << op->getResultTypes();
+  }];
 }
 
 def ROCDL_MubufStoreOp :


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80297.265239.patch
Type: text/x-patch
Size: 1418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200520/15b83147/attachment.bin>