[PATCH] D49097: [RegisterCoalescer] Another fix for subrange join unreachable

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 07:02:08 PDT 2020


foad added a comment.

In D49097#2046517 <https://reviews.llvm.org/D49097#2046517>, @arsenm wrote:

> In D49097#2046460 <https://reviews.llvm.org/D49097#2046460>, @foad wrote:
>
> > The test case added here got fixed by @arsenm's rG0ad1b71fe37af3f3230b40e03e3a511c78152bad <https://reviews.llvm.org/rG0ad1b71fe37af3f3230b40e03e3a511c78152bad> RegisterCoalescer: Assume CR_Replace for SubRangeJoin
> >
> > Do you think that actually fixed the issue here, or do we just need a better test case?
>
>
> I think so, but it wouldn't hurt to extract and commit the test here


rG3c843538048e6439426a555698917051c1f3f3e1 <https://reviews.llvm.org/rG3c843538048e6439426a555698917051c1f3f3e1>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49097/new/

https://reviews.llvm.org/D49097





More information about the llvm-commits mailing list