[PATCH] D80290: [mlir][Linalg] NFC - Simplify GenericNestLoop builder

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 05:56:06 PDT 2020


nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:39
 template <>
-GenericLoopNestRangeBuilder<scf::ParallelOp>::GenericLoopNestRangeBuilder(
+GenericLoopNestRangeBuilder<scf::ForOp>::GenericLoopNestRangeBuilder(
     MutableArrayRef<Value> ivs, ArrayRef<SubViewOp::Range> ranges) {
----------------
ftynse wrote:
> This looks a bit fishy: why does it change from ParallelOp to ForOp?
I blame phab's diff, this is the ForOp version, the ParallelFor is below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80290/new/

https://reviews.llvm.org/D80290





More information about the llvm-commits mailing list