[PATCH] D80147: AMDGPU/GlobalISel: Fix splitting 64-bit extensions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 02:07:12 PDT 2020


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2308-2310
+        // TODO: For sign extend case, we may be better off emitting another
+        // select rather than a shift of the sign bit (although the shift has
+        // better code size).
----------------
Surely the src is always i1 here, so the high part of dst will always be 0 (or undef for anyext)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80147/new/

https://reviews.llvm.org/D80147





More information about the llvm-commits mailing list