[PATCH] D80190: [yaml2obj] - Implement the "Offset" property for the Fill Chunk.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/custom-fill.yaml:305
+
+## 0x123 is an arbirtaty offset.
+# RUN: yaml2obj --docnum=11 -DOFFSET=0x123 -o %t12 %s
----------------
arbitraty -> arbitrary


================
Comment at: llvm/test/tools/yaml2obj/ELF/custom-fill.yaml:309
+
+# OFFSET-MIN:      There are 5 section headers, starting at offset 0x68:
+# OFFSET-MIN:      Section Headers:
----------------
I'm not sure we really need to check the section header table offset, as the position of .bar is sufficient to show the fill impacts the offset calculations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80190/new/

https://reviews.llvm.org/D80190