[PATCH] D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories.

Wed May 20 01:35:10 PDT 2020

jhenderson added reviewers: ikudrin, aprantl.
jhenderson added a comment.

In D80168#2045597 <https://reviews.llvm.org/D80168#2045597>, @saugustine wrote:

> Ping on this?

Hi @saugustine,

Unless something is urgent, the usual practice is to ping after a week rather than 24 hours, as many people have big piles on their review plate, so can't always get to it the next day.

---

The code change looks reasonable, but I might be missing something - how does the test change actually test the new behaviour? I also feel like it would make more sense to test the `getFileNameByIndex` directly using a gtest unit test, since other code beyond the symbolizer might need to use the `RelativeFilePath` stuff in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80168/new/

https://reviews.llvm.org/D80168