[PATCH] D79984: [yaml2obj] - Add a technical suffix for each unnamed chunk.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 20 01:35:09 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, once @MaskRay's comments have been addressed.
================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:420
const Twine &Msg) {
+ // Do not add a space when a Name is empty.
+ if (Name.empty())
----------------
MaskRay wrote:
> `s/a //`
We definitely want the first "a". I think the second one is acceptable either way, so I'd say either leave as-is or "Do not add a space when Name is empty."
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79984/new/
https://reviews.llvm.org/D79984
More information about the llvm-commits
mailing list