[PATCH] D80096: [lit] GoogleTest framework should report failures if test binary crashes

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.

LGTM, with nits.



================
Comment at: llvm/utils/lit/tests/Inputs/googletest-brokendiscovery/DummySubDir/OneTest.py:4
+import sys
+import time
+
----------------
Unnecessary imports


================
Comment at: llvm/utils/lit/tests/Inputs/googletest-brokendiscovery/lit.cfg:2
+import lit.formats
+config.name = 'googletest-brokendiscovery'
+config.test_format = lit.formats.GoogleTest('DummySubDir', 'Test')
----------------
How about naming the test "googletest-error-during-discovery" or "googletest-disovery-failure" since discovery itself isn't "broken"?


================
Comment at: llvm/utils/lit/tests/googletest-brokendiscovery.py:1
+# Check that the per test timeout is enforced when running GTest tests.
+#
----------------
Copy & pasted comment


================
Comment at: llvm/utils/lit/tests/googletest-brokendiscovery.py:9
+# CHECK: Failing Tests (1):
+# CHECK:   googletest-brokendiscovery :: {{[Dd]ummy[Ss]ub[Dd]ir}}/OneTest.py/failed_to_discover_tests_from_gtest
+# CHECK: Unexpected Failures: 1
----------------
Maybe just name the dir "subdir" to avoid the need for this regex


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80096/new/

https://reviews.llvm.org/D80096