[PATCH] D79902: [IR] Make Module::setProfileSummary to replace an existing ProfileSummary flag.

[Rong Xu via llvm-commits]

sorry. I do mean "looks good to me".

On Tue, May 19, 2020 at 1:04 PM Xinliang David Li <davidxl at google.com>
wrote:

> do you mean 'looks good to me'?
>
> On Tue, May 19, 2020 at 12:37 PM Rong Xu via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> xur added a comment.
>>
>> I noticed the same issue when I implemented CSFDO -- I initially reused
>> the same summary name for CSFDO as in FDO.
>> Exiting of two module flags with the same name sometime breaks the build
>> (not always, if I remember correctly).
>>
>> This fix looks to me.
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D79902/new/
>>
>> https://reviews.llvm.org/D79902
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200519/daf6aedf/attachment.html>