[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

Tue May 19 22:30:22 PDT 2020

ychen added a comment.

In D71261#2045798 <https://reviews.llvm.org/D71261#2045798>, @tejohnson wrote:

> In D71261#2043242 <https://reviews.llvm.org/D71261#2043242>, @ychen wrote:
>
> > In D71261#2038881 <https://reviews.llvm.org/D71261#2038881>, @tejohnson wrote:
> >
> > > It would be good to add equivalent support to gold-plugin.cpp as well so that those remain in sync on functionality.
> >
> >
> > It seems that the gold plugin API does not work well with the pre-upgrade this patch is proposing. Without pre-upgrade, the upgrade happens during `InputFile::create` in `claim_file_hook`. Pre-upgrade needs to happen before `claim_file_hook` where something like `vector<Input_path>` is available. The plugin API does not seem to have this hook. Not quite sure how to proceed with this restriction.
>
>
> That's true the claim_file_hook is called on files one by one from gold. But there is a second call to InputFile::create for each claimed module, done from addModule, which I assume will upgrade them a second time. In that case the caller has the whole list of input files that were claimed, so something similar could presumably be done there.

Thanks for the pointer! I will look into that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261