[PATCH] D79976: [LV] Handle Fold-Tail of loops with vectorizarion factor (VF) equal to 1

Anh Tuyen Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 21:58:14 PDT 2020


anhtuyen added a comment.

In D79976#2045738 <https://reviews.llvm.org/D79976#2045738>, @anhtuyen wrote:

> In D79976#2045007 <https://reviews.llvm.org/D79976#2045007>, @Ayal wrote:
>
> > This looks good to me, thanks! Please wait a day or so if @fhahn has further comments.
> >
> > As noted, it would now be good to also extend pr45679-fold-tail-by-masking.ll with an additional RUN of -force-vector-width=1 and -force-vector-interleave=4.
>
>
> It is very kind of you, Ayal @Ayal , and I thank you very much. As you have mentioned, I surely will wait a day or two to see whether Florian and Bardia might have further comments.
>  About pr45679-fold-tail-by-masking.ll, do you want me to add it for completeness? 
>  With VF=1, the testcase does not go through the code changed by this patch (b/c its BackedgeTakenCount is null).


Oh, I think I know what you meant now: adding the test pr45679-fold-tail-by-masking.ll **AFTER** applying your patch https://reviews.llvm.org/D80085. I will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79976/new/

https://reviews.llvm.org/D79976





More information about the llvm-commits mailing list