[PATCH] D79269: [NativeSession] Implement NativeSession::findSymbolByAddress.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 17:39:07 PDT 2020


morehouse added a comment.

In D79269#2045451 <https://reviews.llvm.org/D79269#2045451>, @akhuang wrote:

> @morehouse Do you happen to know what would cause undefined symbols to be added? I reproduced it and it seems like it started from implementing loadDataForEXE <https://github.com/llvm/llvm-project/blob/fe1a3a7e8c8be33968b9a768666489823dabab10/llvm/lib/DebugInfo/PDB/PDB.cpp#L36> (in https://reviews.llvm.org/D78128)


Does either patch introduce new dependencies for the symbolizer?  Maybe we need to add another library here <https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh#L160>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79269/new/

https://reviews.llvm.org/D79269





More information about the llvm-commits mailing list