[PATCH] D79597: [asan_symbolize] Fix bug handling C++ symbols when using Atos.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 16:34:46 PDT 2020


delcypher marked an inline comment as done.
delcypher added a comment.

In D79597#2027534 <https://reviews.llvm.org/D79597#2027534>, @yln wrote:

> LGTM with suggested update for the comment.  Thanks!
>
> > I'm guessing the idea here was to try to drop any listed arguments for the function being symbolized.
>
> If you are able to find out why this was done quickly (in a few minutes), then please document the reason here in this review thread.


I couldn't figure out why this was done based on git blame.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79597/new/

https://reviews.llvm.org/D79597





More information about the llvm-commits mailing list