[PATCH] D79626: [PowerPC][NFC] Split PPCELFStreamer::emitInstruction

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 15:28:07 PDT 2020

Previous message: [PATCH] D80252: AMDGPU: Fix backwards s_cselect_* operands
Next message: [llvm] 08ae945 - GlobalISel: Copy correct flags to select
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

NeHuang added a comment.

LGTM except one nit: Is it better to change the function name from `emitPrefixInstruction` to `emitPrefixedInstruction`? (referred to `Emitter->isPrefixedInstruction`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79626/new/

https://reviews.llvm.org/D79626

Previous message: [PATCH] D80252: AMDGPU: Fix backwards s_cselect_* operands
Next message: [llvm] 08ae945 - GlobalISel: Copy correct flags to select
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list