[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

Most of my comments are related to the fact that we are now inserting P10 <https://reviews.llvm.org/P10> between P9 <https://reviews.llvm.org/P9> and Future and so a few things need to change for the Future code to sit on top of P10 <https://reviews.llvm.org/P10> now.



================
Comment at: clang/test/Preprocessor/init-ppc64.c:652
 // PPCFUTURE:#define _ARCH_PPCSQ 1
 // PPCFUTURE:#define _ARCH_PWR4 1
 // PPCFUTURE:#define _ARCH_PWR5 1
----------------
Since we are adding P10 between P9 and Future we should add another line here:
```
PPCFUTURE:#define _ARCH_PWR10 1
```


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:340
+  list<SubtargetFeature> P10SpecificFeatures =
+    [FeaturePrefixInstrs, FeaturePCRelativeMemops];
+  list<SubtargetFeature> P10InheritableFeatures =
----------------
I think these can be moved up to `P10AdditionalFeatures`. That way everything on P10 is now inheritable by future and we don't have to specify anything for `FutureSpecificFeatures`.


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:351
   list<SubtargetFeature> FutureSpecificFeatures =
     [FeaturePrefixInstrs, FeaturePCRelativeMemops];
   list<SubtargetFeature> FutureInheritableFeatures =
----------------
These features are now no longer `FutureSpecificFeatures` I would think that they would now be part of Power10 and should be inherited by future CPU. 


================
Comment at: llvm/test/CodeGen/PowerPC/check-cpu.ll:11
 
 ; Test mcpu=future that should be recognized on PowerPC.
 
----------------
nit:
We should probably update this comment too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80020/new/

https://reviews.llvm.org/D80020