[PATCH] D62884: [lld] Explicitly ignore comdat groups when parsing LTO object

[Christy Lee via Phabricator via llvm-commits]

christylee added a comment.

> However the behavior before and after this change should be the same, since I believe they were being ignored before this change too

I tried an earlier linker version without this patch and lld also did not de-duplicate.  My guess is since with thinlto we are not doing true whole program analysis, there's still some leftover comdat groups we need to clean up at link time.

> Do you see any other side effects of settings this to false?

I don't think so.  My understanding is that in the monolithic lto case, if we set this to false then no extra comdat sections will be removed.  If we set it to true for thinlto, lld will then link as normal.

Let me put up a diff to set ignoreComdats to false for thinlto and request more comments.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62884/new/

https://reviews.llvm.org/D62884