[PATCH] D80100: [mlir][Vector] Add option to fully unroll for VectorTransfer to SCF lowering

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 11:28:47 PDT 2020


aartbik added inline comments.


================
Comment at: mlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h:78
+///
+/// Case B: Permutation Map permutes and/or broadcast.
+/// ======================================================
----------------
nit: broadcasts (same verb form)


================
Comment at: mlir/test/Conversion/VectorToLoops/vector-to-loops.mlir:225
 //  CHECK-SAME:   %[[base:[a-zA-Z0-9]+]]: index
-func @transfer_read_progressive(%A : memref<?x?xf32>, %base: index) -> vector<17x15xf32> {
+// FULL-UNROLL-LABEL: transfer_read_progressive(
+//  FULL-UNROLL-SAME:   %[[A:[a-zA-Z0-9]+]]: memref<?x?xf32>,
----------------
empty line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80100/new/

https://reviews.llvm.org/D80100





More information about the llvm-commits mailing list