[PATCH] D80180: [mlir] Add custom assembly formats to shape.witness ops.

[Sean Silva via Phabricator via llvm-commits]

silvas requested changes to this revision.
silvas added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/test/Dialect/Shape/ops.mlir:74
   %1 = shape.const_shape [1, 2, 3]
-  %w0 = "shape.cstr_broadcastable"(%0, %1) : (!shape.shape, !shape.shape) -> !shape.witness
-  %w1 = "shape.cstr_eq"(%0, %1) : (!shape.shape, !shape.shape) -> !shape.witness
-  %w3 = "shape.assuming_all"(%w0, %w1) : (!shape.witness, !shape.witness) -> !shape.witness
+  %w0 = shape.cstr_broadcastable(%0, %1)
+  %w1 = shape.cstr_eq(%0, %1)
----------------
can we remove the parentheses? It's easier to type and read IMO and is consistent with many std and other ops (like `addi`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80180/new/

https://reviews.llvm.org/D80180