[PATCH] D80110: [VPlan] Remove unique_ptr from VPBranchOnRecipeMask (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 09:49:21 PDT 2020


Ayal added a comment.

In D80110#2044051 <https://reviews.llvm.org/D80110#2044051>, @fhahn wrote:

> In D80110#2041354 <https://reviews.llvm.org/D80110#2041354>, @Ayal wrote:
>
> > Perhaps clearer to introduce getMask() as in other recipes, and check if it returns null?
>
>
> Thanks Ayal, I've added & used a getMask() method in the committed version!


LGTM :-)
Could have inlined { VPValue *BlockInMask = getMask(); if (BlockInMask) }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80110/new/

https://reviews.llvm.org/D80110





More information about the llvm-commits mailing list