[PATCH] D79926: [lld-macho] Support .subsections_via_symbols

Tue May 19 08:41:43 PDT 2020

int3 marked an inline comment as done.
int3 added inline comments.

================
Comment at: lld/MachO/InputFiles.cpp:318
+    bool subsectionsViaSymbols = hdr->flags & MH_SUBSECTIONS_VIA_SYMBOLS;
+    parseSymbols(nList, strtab, subsectionsViaSymbols);
   }
----------------
thakis wrote:
> This breaks the build on Linux: http://45.33.8.238/linux/18060/step_4.txt
> And Windows: http://45.33.8.238/win/15558/step_4.txt
> 
> Please take a look, and revert if it takes a while to investigate.
weird, I'd wouldn't have expected ArrayRef to construct an std::vector :/ reverted for now, thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79926/new/

https://reviews.llvm.org/D79926