[PATCH] D80042: [gn build] Add a flag to provide the path to zlib on Windows.

Sébastien Marchand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 08:07:41 PDT 2020


sebmarchand added a comment.

In D80042#2042904 <https://reviews.llvm.org/D80042#2042904>, @thakis wrote:

> Thanks for the patch! The way I thought this would look is to have the arg in http://llvm-cs.pcc.me.uk/utils/gn/build/libs/zlib/enable.gni#3 and then change the lower declare_args block to have `  llvm_enable_zlib = host_os != "win" || zlib_path != ""`. Does that make sense?


Thanks, that makes sense. The new arg is already in utils/gn/build/libs/zlib/enable.gni , did you simply meant to put it in a new declare_args block before the existing one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80042/new/

https://reviews.llvm.org/D80042





More information about the llvm-commits mailing list