[PATCH] D79991: [TableGen] Fix non-standard escape warnings for braces in InstAlias
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 19 04:17:31 PDT 2020
hfinkel added inline comments.
================
Comment at: llvm/utils/TableGen/AsmWriterEmitter.cpp:808
CodeGenInstruction::FlattenAsmStringVariants(CGA.AsmString, Variant);
+ UnescapeString(FlatAliasAsmString);
----------------
Is this unescaping the right thing to do in general, or do we really just want to do it for the braces? What if there were an escaped quote in the string?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79991/new/
https://reviews.llvm.org/D79991
More information about the llvm-commits
mailing list