[PATCH] D80123: [yaml2obj][obj2yaml] - Stop using square brackets for unique suffixes.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml:35-36
+    Type: SHT_PROGBITS
+  - Name: '.foo2 ()'
+    Type: SHT_PROGBITS
 
----------------
jhenderson wrote:
> If I understand it correctly, `'.foo2 (asbdjasbdjasbd)'` is also a valid unique suffix. Perhaps worth showing that arbitrary contents are allowed in there?
We have such tests. See `duplicate-symbol-and-section-names.yaml` above:

```
--- !ELF
FileHeader:
  Class:   ELFCLASS64
  Data:    ELFDATA2LSB
  Type:    ET_REL
  Machine: EM_X86_64
Sections:
  - Name: .foo
    Type: SHT_PROGBITS
  - Name: '.foo (555)'
    Type: SHT_PROGBITS
  - Name: '.foo (random_tag)'
    Type: SHT_PROGBITS
  - Name: .bar
    Type: SHT_PROGBITS
  - Name: '.bar (666)'
    Type: SHT_PROGBITS
  - Name: '.bar (random_tag)'
    Type: SHT_PROGBITS
Symbols:
  - Name: 'localfoo (111)'
  - Name: 'localfoo (222)'
  - Name: 'localfoo (random_tag)'
  - Name: 'localbar (333)'
  - Name: 'localbar (444)'
  - Name: 'localbar (random_tag)'
```


================
Comment at: llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml:18
   - Name: localfoo
-  - Name: 'localfoo [1]'
+  - Name: 'localfoo (1)'
 
----------------
jhenderson wrote:
> Same comment as above. Perhaps worth showing that the contents of the '()' can be arbitrary.
The same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80123/new/

https://reviews.llvm.org/D80123