[PATCH] D80107: [SVE] Remove IITDescriptor::ScalableVecArgument

[David Sherwood via Phabricator via llvm-commits]

david-arm marked 4 inline comments as done.
david-arm added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.h:110
 
+    struct VectorWidth {
+      unsigned NumElts : 30;
----------------
efriedma wrote:
> Can you just use ElementCount here, instead of defining your own struct?
> 
> If you do think it's necessary to pack this struct, please ensure that the struct can hold all the values ElementCount can hold.  I don't want the possibility of new mysterious failures due to overflow.
ElementCount isn't designed to be embedded in another structures, but I do take your point. I've done something similar to how it's done in VectorType - made sure we have enough storage for the element count and added a getVectorElementCount() helper that returns a ElementCount.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80107/new/

https://reviews.llvm.org/D80107