[PATCH] D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects.

Mon May 18 23:57:40 PDT 2020

herhut added a comment.

In D78917#2042440 <https://reviews.llvm.org/D78917#2042440>, @mehdi_amini wrote:

> In D78917#2041123 <https://reviews.llvm.org/D78917#2041123>, @dfki-mako wrote:
>
> > @mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.
>
>
> From what I see above, this revision was not approved without these though? Why did this land?

We talked about this offline and decided to move forward with this change. We did not feel this was controversial and also easy to roll back in case there are comments later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78917/new/

https://reviews.llvm.org/D78917