[PATCH] D80078: [LoopSimplify] don't separate nested loops with convergent calls
Sameer Sahasrabuddhe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 18 19:32:19 PDT 2020
sameerds marked an inline comment as done.
sameerds added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopSimplify.cpp:244
+ // convergent function calls in GVNHoist and JumpThreading.
+ for (auto BB : L->blocks()) {
+ for (auto &II : *BB) {
----------------
arsenm wrote:
> I thought we had a hasConvergentOp on loops that would avoid scanning through all the blocks again
That is available when LoopAccessAnalysis is used. But LoopSimplify does not already use it, and it seems a bit expensive for just this one use.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80078/new/
https://reviews.llvm.org/D80078
More information about the llvm-commits
mailing list