[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments.



================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:3458
+               EnterScope(Scope::OpenMPDirectiveScope | Scope::DeclScope),
+               ParseOpenMPIteratorsExpr()));
     Tail = Actions.ActOnFinishFullExpr(Tail.get(), T.getOpenLocation(),
----------------
Please make this a conditional. Having a 5 line expression with ternary and comma operator is hard to read.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:18836
+    }
+    Vars.push_back(RefExpr->IgnoreParenImpCasts());
+  }
----------------
I you can, reuse SimpleExpr here and above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80148/new/

https://reviews.llvm.org/D80148