[PATCH] D80100: [mlir][Vector] Add option to fully unroll for VectorTransfer to SCF lowering

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h:16
 class MLIRContext;
+class LogicalResult;
 class OwningRewritePatternList;
----------------
`struct` or you'll break msvc


================
Comment at: mlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h:58
+/// ```
+/// Lowers to pseudo-IR resembling:
+struct VectorTransferToSCFOptions {
----------------
Something's missing here


================
Comment at: mlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h:60
+struct VectorTransferToSCFOptions {
+  /// The tile sizes by which to tile.
+  bool unroll = false;
----------------
Copy-pasta?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80100/new/

https://reviews.llvm.org/D80100