[PATCH] D79398: [dsymutil] Add reproducers to dsymutil

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/tools/dsymutil/X86/reproducer.test:27
+CHECK:  DW_TAG_compile_unit
+CHECK:    DW_AT_producer ("Apple LLVM version 6.0 (clang-600.0.39) (based on LLVM 3.5svn)")
+CHECK:    DW_AT_language (DW_LANG_C99)
----------------
most of these should be CHECK-NEXT?


================
Comment at: llvm/test/tools/dsymutil/cmdline.test:3
 HELP: OVERVIEW: manipulate archived DWARF debug symbol files.
 HELP: USAGE: {{.*}}dsymutil{{[^ ]*}} [options] <input files>
 HELP-NOT: -reverse-iterate
----------------
What do you think about adding 

`RUN: cat dsymutil.rst | FileCheck --check-prefix=HELP `

here to ensure all options are documented?


================
Comment at: llvm/tools/dsymutil/Options.td:161
+
+def use_reproducer: Separate<["--", "-"], "use-reproducer">,
+  MetaVarName<"<path>">,
----------------
JDevlieghere wrote:
> aprantl wrote:
> > What about `--record-reproducer` and `--replay-reproducer`?
> It's funny you say this because that's what I had originally. It would certainly be more consistent with `lldb`. I changed it because I don't think "replay" is accurate for dsymutil. I don't plan on capturing anything beyond the input files, so really there's nothing being "replayed". The functionality is more closely related to what `clang` does, which is why I went with "generate" instead of "capture". 
Can you add these to the man page as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79398/new/

https://reviews.llvm.org/D79398