[PATCH] D80065: AMDGPU: Fix illegally constant folding from V_MOV_B32_sdwa

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

Technically even SDWA or DPP for can move immediate, aren't they? I.e.:

  v_mov_b32_sdwa v0, 1 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD ; encoding: [0xf9,0x02,0x00,0x7e,0x81,0x16,0x86,0x00]

Should not SDWA peephole be fixed instead? Interpretation of modifiers as materialized immediate seems to be just a bug.

Moreover, we seem to have another bug in v_mov_b32:

  <stdin>:1:15: error: not a valid operand.
  v_mov_b32 v0, -v1

This is a legal form but we do not support it. If we fix that then we probably will have issue with src0_modifiers again, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80065/new/

https://reviews.llvm.org/D80065