[PATCH] D80134: [mlir] DialectConversion: avoid double-free when rolling back op creation

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Thanks! 
This must not have been fun to debug..



================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:672
+/// order and if the nested ops were created before the parent op. This function
+/// does not need to collect nested ops recurisvely because it is expected to
+/// also be called for each nested op when it is about to be deleted.
----------------
recursively


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80134/new/

https://reviews.llvm.org/D80134