[PATCH] D76985: [LVI] Don't require DominatorTree in LVI (NFC)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 09:42:11 PDT 2020


nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:458
   // Flush only the Dominator Tree.
   DTU->getDomTree();
-  LVI->enableDT();
----------------
fhahn wrote:
> I think we flushed the DT updates here for LVI only? It would be good to drop this here (less frequent applying of updates should be quicker). If it is required somewhere else, we should move it there.
I've moved the getDomTree() call to the printLVI() invocation. It doesn't really make a difference in practice because the DTU gets destroyed right after the runImpl() call, but at least this is clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76985/new/

https://reviews.llvm.org/D76985





More information about the llvm-commits mailing list