[PATCH] D78306: [flang] Use LLVM's flags

[Richard Barton via Phabricator via llvm-commits]

richard.barton.arm added a comment.

We discussed this on the technical call on 18 May - see https://docs.google.com/document/d/1Z2U5UAtJ-Dag5wlMaLaW1KRmNgENNAYynJqLW2j2AZQ

Summarising the discussion:

- We should split the flags fixes (which are agreed) from the flipping of the default for -Werror into separate patches. Suggest this patch be modified to fix the issues seen on Windows without changing the default value of -Werror.
- On the call we proposed a compromise of keeping -Werror on by default for Flang but having a local Flang CMake flag to disable it that folks can use that. @isuruf would that unblock you and fix the issue that caused you to submit the patch originally?
- We wondered whether the way the Cmake files are written already supports this through adding -DLLVM_ENABLE_WARNINGS=0 to the build line. Pat McCormick is going to look and reply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78306/new/

https://reviews.llvm.org/D78306