[PATCH] D80113: [mlir] Support optional attributes in assembly formats
Jean-Michel Gorius via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 18 09:40:07 PDT 2020
Kayjukh accepted this revision.
Kayjukh added a comment.
LGTM after fixing the use of curly braces.
================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:893
+ // Collect the optional attributes.
+ if (auto *opt = dyn_cast<OptionalElement>(it.get()))
+ for (auto &elem : opt->getElements())
----------------
nit: It could be advisable to use some curly braces for such nested statements.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80113/new/
https://reviews.llvm.org/D80113
More information about the llvm-commits
mailing list