[PATCH] D80124: [Matrix] Make matrix.multiply variadic, accept optional NUW/NSW flags.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:936
+                      IRBuilder<> &Builder, bool AllowContraction, bool HasNUW,
+                      bool HasNSW, unsigned &NumComputeOps) {
     NumComputeOps += getNumOps(A->getType());
----------------
has this reached a point where you want a separate `LowerMatrixIntrinisicsOptions().setHasNUW(true).setHasNSW(false)`and make this into 
`createMulAdd(Value *Sum, Value *A, Value *B, LowerMatrixIntrinisicsOptions options)` ?

As a future user of the potential per-operand row/col major arguments it would make things much nicer IMO.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80124/new/

https://reviews.llvm.org/D80124