[PATCH] D80092: [mlir][Vector] Make minor identity permutation map optional in transfer op printing and parsing

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked an inline comment as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorOps.cpp:1337
+  SmallVector<StringRef, 1> elidedAttrs;
+  if (AffineMap::isMinorIdentity(op.permutation_map()))
+    elidedAttrs.push_back(op.getPermutationMapAttrName());
----------------
ftynse wrote:
> Should we also check that it is a minor identity of the correct size, i.e. has the expected number of equal dimensions? Or is it impossible for valid ops?
since it's inferred we can just construct and test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80092/new/

https://reviews.llvm.org/D80092