[PATCH] D80123: [yaml2obj] - Stop using square brackets for unique suffixes.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: cmtice, rupprecht, hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a project: LLVM.

For describing section/symbol names we can use unique suffixes,
e.g:

  - Name: '.foo [1]`
  - Name: '.foo [2]`

It can be a problem (see https://reviews.llvm.org/D79984#inline-734829),
because `[]` are sometimes used to describe a macros:

  - Name: "[[a0]]"

Seems the better approach is to use something else, like "()" or "<>".
This patch does it and refactors the code related.


https://reviews.llvm.org/D80123

Files:
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/test/Object/X86/obj2yaml-dup-section-name.s
  llvm/test/tools/llvm-dwarfdump/X86/section_sizes_elf.test
  llvm/test/tools/llvm-gsymutil/X86/elf-dwarf.yaml
  llvm/test/tools/llvm-objcopy/ELF/strip-dwo-groups.test
  llvm/test/tools/llvm-readobj/ELF/stack-sizes.test
  llvm/test/tools/obj2yaml/ELF/duplicate-symbol-and-section-names.yaml
  llvm/test/tools/obj2yaml/ELF/program-headers.yaml
  llvm/test/tools/yaml2obj/ELF/call-graph-profile-section.yaml
  llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml
  llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml
  llvm/test/tools/yaml2obj/ELF/stack-sizes.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80123.264617.patch
Type: text/x-patch
Size: 15670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200518/546e58c5/attachment.bin>