[PATCH] D78717: [SystemZ] Implement -fstack-clash-protection

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 05:52:34 PDT 2020


uweigand added a comment.

In D78717#2041281 <https://reviews.llvm.org/D78717#2041281>, @jonpa wrote:

> In D78717#2038456 <https://reviews.llvm.org/D78717#2038456>, @serge-sans-paille wrote:
>
> > In D78717#2036041 <https://reviews.llvm.org/D78717#2036041>, @jonpa wrote:
> >
> > > Normally, I would have expected a pseudo MachineInstruction to be built here with an immediate operand for the size requirement...
> >
> >
> > That sounds very nice. If you go that way I'll happily update the X86 code accordingly. Or If you point me to some example / doc / code on pseudo MachineInstruction, I can implement that too.
>
>
> @uweigand : Would you rather use a target pseudo instruction for this rather than using a call with metadata?


Using a pseudo is probably a cleaner solution, yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78717/new/

https://reviews.llvm.org/D78717





More information about the llvm-commits mailing list