[PATCH] D80119: [AMDGPU/MemOpsCluster] Code clean-up around mem ops clustering logic

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 05:52:31 PDT 2020


hsmhsm created this revision.
hsmhsm added reviewers: foad, rampitec, arsenm, vpykhtin, javedabsar.
Herald added subscribers: llvm-commits, kerbowa, javed.absar, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl, MatzeB.
Herald added a project: LLVM.

Clean-up code around mem ops clustering logic.
(1) NumLoads argument can initially be set to 2 instead of 1, this avoids incrementing NumLoads while calling shouldClusterMemOps()
(2) Re-arrange the code within clusterNeighboringMemOps(), so that the code is more convenient to understand
(3) Improve the logic within shouldClusterMemOps() and remove all `FIXME`s


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80119

Files:
  llvm/lib/CodeGen/MachineScheduler.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80119.264595.patch
Type: text/x-patch
Size: 7278 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200518/0f163322/attachment.bin>


More information about the llvm-commits mailing list