[PATCH] D79927: [MLIR] [Linalg] Add option to use the partial view after promotion.

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 18 05:20:04 PDT 2020


ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp:78
   if (options.operandsToPromote.hasValue()) {
-    for (unsigned idx : options.operandsToPromote.getValue()) {
-      auto *op = linalgOp.getBuffer(idx).getDefiningOp();
-      if (auto sv = dyn_cast_or_null<SubViewOp>(op))
+    for (const auto &it :
+         llvm::enumerate(options.operandsToPromote.getValue())) {
----------------
Please don't use references with `llvm::enumerate`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79927/new/

https://reviews.llvm.org/D79927





More information about the llvm-commits mailing list