[PATCH] D80056: GlobalISel: Merge G_PTR_MASK with llvm.ptrmask intrinsic

[Dominik Montada via Phabricator via llvm-commits]

gargaroff accepted this revision.
gargaroff added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. Thanks for unifying the semantics!



================
Comment at: llvm/test/MachineVerifier/test_g_ptrmask.mir:19
+
+    ; CHECK:  Bad machine code: Type mismatch in generic instruction
+    %4:_(p0) = G_PTRMASK %2, %2
----------------
Should the verifier report where the type mismatch is? It already reports if the destination of the mask is incorrect. Shouldn't it do the same for the source?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80056/new/

https://reviews.llvm.org/D80056