[PATCH] D73260: [Alignement][NFC] Deprecate untyped CreateAlignedLoad

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InterleavedAccess.cpp:219
     Instruction *NewLoad =
-        Builder.CreateAlignedLoad(VecBaseTy, NewBasePtr, LI->getAlignment());
+        Builder.CreateAlignedLoad(VecBaseTy, NewBasePtr, LI->getAlign());
     DecomposedVectors.push_back(NewLoad);
----------------
efriedma wrote:
> RKSimon wrote:
> > @gchatelet This is causing misaligned load accesses: https://bugs.llvm.org/show_bug.cgi?id=45957
> This change is NFC.  Semantically, this code hasn't changed since D24681.
I think the code that just copies the old alignment is faulty: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/X86/X86InterleavedAccess.cpp#L219


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73260/new/

https://reviews.llvm.org/D73260