[PATCH] D80075: [MLIR][cmake][NFC] Update linkage checker for mlir-opt

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 17 14:23:09 PDT 2020


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf88c7fe46b37: [MLIR][cmake][NFC] Update linkage checker for mlir-opt (authored by stephenneuendorffer).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80075/new/

https://reviews.llvm.org/D80075

Files:
  mlir/cmake/modules/AddMLIR.cmake
  mlir/tools/mlir-opt/CMakeLists.txt


Index: mlir/tools/mlir-opt/CMakeLists.txt
===================================================================
--- mlir/tools/mlir-opt/CMakeLists.txt
+++ mlir/tools/mlir-opt/CMakeLists.txt
@@ -52,4 +52,4 @@
 target_link_libraries(mlir-opt PRIVATE ${LIBS})
 llvm_update_compile_flags(mlir-opt)
 
-mlir_check_link_libraries(mlir-opt)
+mlir_check_all_link_libraries(mlir-opt)
Index: mlir/cmake/modules/AddMLIR.cmake
===================================================================
--- mlir/cmake/modules/AddMLIR.cmake
+++ mlir/cmake/modules/AddMLIR.cmake
@@ -179,7 +179,7 @@
           # same symbol might be loaded from 2 separate libraries.  This
           # often comes from referring to an LLVM library target
           # explicitly in target_link_libraries()
-          message("WARNING: ${l} links LLVM and ${lib}!")
+          message("WARNING: ${name} links LLVM and ${lib}!")
         endif()
       endif()
     endforeach()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80075.264513.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200517/ac0b3f3f/attachment.bin>


More information about the llvm-commits mailing list