[PATCH] D80081: [LoopUnroll] Reset PeelCount on exit before computePeelCount.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 17 14:23:03 PDT 2020


efriedma added a comment.

If there are separate values "desired peel count" and "actual number of times we've decided to peel", I'd prefer to store them in separate variables; resetting the peel count like this seems overly complicated.

> Note that now it is not possible to combine peeling and unrolling in the same step using LoopUnrollPass I think, hence the test changes.

Do we want to allow this?  It seems reasonable to both peel and partially unroll a loop, although we probably want compute the unrolll cost on the peeled loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80081/new/

https://reviews.llvm.org/D80081





More information about the llvm-commits mailing list