[PATCH] D80002: [yaml2obj] - Implement the "SectionHeaderTable" tag.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 17 03:43:38 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers.yaml:39
+SectionHeaderTable:
+  Sections:
+    - Name: [[SEC1]]
----------------
MaskRay wrote:
> Can `Sections` be omitted?
It was done intentionally. I am thinking about adding a one more "Location"/"Offset" tag here in a follow-up
which should allow placing the table before/after sections or, perhaps, to a particular location either:

```
SectionHeaderTable:
  Offset: AutoBefore
  Sections:
  ...
```

(Something like was mentioned here: https://reviews.llvm.org/D78927#inline-732176)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80002/new/

https://reviews.llvm.org/D80002





More information about the llvm-commits mailing list