[PATCH] D78459: [AVR] Don't adjust for instruction size

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 16 20:08:53 PDT 2020


dylanmckay added a comment.

Hey @aykevl, I like this patch, it definitely removes a special cases that intuitively feels like it should not need to be there. Nice work

Before merging this, I want to run it under the emulated AVR integration tests I've been working on, just to build 100% confidence that it does what it says on the tin. The tests I've been working on are getting very close to useful now, but it may be a couple more weeks before I get to approving this. I remember writing this particular logic quite some time ago, and it felt nontrivial for some reason I cannot remember.

Keep up the good work, I'll come back to this very soon


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78459/new/

https://reviews.llvm.org/D78459





More information about the llvm-commits mailing list