[PATCH] D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor.

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a couple minor comments.



================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:593
+      if (!PreviousLayoutSuccessor || !isSuccessor(PreviousLayoutSuccessor)
+          || PreviousLayoutSuccessor->isEHPad())
         return;
----------------
nit: please clang-format


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:622
+  assert(PreviousLayoutSuccessor);
+  assert(isSuccessor(PreviousLayoutSuccessor));
 
----------------
Might as well `assert(!PreviousLayoutSuccessor->isEHPad())`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79605/new/

https://reviews.llvm.org/D79605