[PATCH] D79832: Initial commit for the elf x86 implementation for jitlink

[Jared Wyles via Phabricator via llvm-commits]

jaredwy marked 6 inline comments as done.
jaredwy added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:71-72
+      auto Symbols = Obj.symbols(&SecRef);
+      if (errorToBool(std::move(Symbols.takeError())))
+        continue;
+
----------------
lhames wrote:
> This should error out rather than continuing.
I have this fixed this locally. As discussed this now outputs the error to dgbs() rather than just dropping it. 


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:160
+
+    /// We only have 256 section indexes: Use a vector rather than a map.
+    std::vector<std::vector<object::ELFFile<object::ELF64LE>::Elf_Shdr_Range *>>
----------------
lhames wrote:
> MachO only has 256 sections indexes (the section index field is 8-bit), but I thought ELF had more?
I have removed this locally as I found out that the elf object can handle this lookup for me. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79832/new/

https://reviews.llvm.org/D79832