[PATCH] D80019: [WebAssembly] Fixed debugloc in DebugFixup pass

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp:121
               BuildMI(*Prev.DebugValue->getParent(), std::next(MII),
-                      MI.getDebugLoc(), TII->get(WebAssembly::DBG_VALUE), false,
+                      Prev.DebugValue->getDebugLoc(), TII->get(WebAssembly::DBG_VALUE), false,
                       Register(), Prev.DebugValue->getOperand(2).getMetadata(),
----------------
aardappel wrote:
> aheejin wrote:
> > clang-format. You can use https://reviews.llvm.org/project/view/78/ to detect this kind of issues. (This emits a lot of errors for other people's code, so it's a bit annoying.)
> Thanks, joined that group. I did `git clang-format` this CL though.
Locally running `clang-format` shows diff of this:
```
--- a/llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp
@@ -118,8 +118,9 @@ bool WebAssemblyDebugFixup::runOnMachineFunction(MachineFunction &MF) {
               // a $noreg DBG_VALUE for the variable to end it, right after
               // the current instruction.
               BuildMI(*Prev.DebugValue->getParent(), std::next(MII),
-                      Prev.DebugValue->getDebugLoc(), TII->get(WebAssembly::DBG_VALUE), false,
-                      Register(), Prev.DebugValue->getOperand(2).getMetadata(),
+                      Prev.DebugValue->getDebugLoc(),
+                      TII->get(WebAssembly::DBG_VALUE), false, Register(),
+                      Prev.DebugValue->getOperand(2).getMetadata(),
                       Prev.DebugValue->getOperand(3).getMetadata());
             }
           }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80019/new/

https://reviews.llvm.org/D80019