[PATCH] D79753: [mlir][StandardToSPIRV] Fix signedness issue in bitwidth emulation.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung marked an inline comment as done.
hanchung added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp:175
+CHECK_UNSIGNED_OP(spirv::UGreaterThanOp);
+CHECK_UNSIGNED_OP(spirv::UGreaterThanEqualOp);
+
----------------
hanchung wrote:
> antiagainst wrote:
> > There are other ops like `AtomicUMax`? Maybe do some regex like `def SPV_\w*U\w+Op` inside `include/Dialect/SPIRV/`?
> Yes, there are other ops. I only list the ops I found in this file. I'm not sure if we can do regex on macro definition. I checked in the doc, and couldn't find it. Let's handle it with TreatOperandsAsUnsignedInteger approach?
> 
> Would you like me to list other ops that we could find in include/Dialect/SPIRV here? 
I list other ops as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79753/new/

https://reviews.llvm.org/D79753